Skip to content

Conversation

@Azgaar
Copy link
Owner

@Azgaar Azgaar commented Jul 21, 2024

Description

Alternative grids, based on idea of #832.

Type of change

  • Bug fix
  • New feature
  • Refactoring / style
  • Documentation update / chore
  • Other (please describe)

Versioning

  • Version is updated
  • Changed files hash is updated

@Azgaar Azgaar self-assigned this Jul 21, 2024
@netlify
Copy link

netlify bot commented Jul 21, 2024

Deploy Preview for afmg ready!

Name Link
🔨 Latest commit 66004de
🔍 Latest deploy log https://app.netlify.com/sites/afmg/deploys/66a77615ec41060008923bf9
😎 Deploy Preview https://deploy-preview-1100--afmg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Azgaar Azgaar mentioned this pull request Jul 29, 2024
5 tasks
@Azgaar
Copy link
Owner Author

Azgaar commented Jul 29, 2024

Generally it works, but there are a couple of issues with hex grid geography that prevent from releasing the change.

  1. Hex geometry is not ideal
    Voronoi calculation algorithm does not provide ideas voronoi cells geometry for hex points, probably due to algo simplifications.
image

The better option would be to calculate hex grid directly and not Voronoi grid. But it will take time to implement and custom solution will probably be bugged.

  1. Generation code relies on grid to be a rectangular grid of cellsX x cellsY cells.
    The issue is bypassed by adding additional cells to odd rows that make cellsX a stable value, but there are still unknown issues (possible related) on bigger cells count.

  2. This is a low-priority ticket.
    Most users probably don't need it. Regular grid looks too artificial while the whole FMG idea was to generate more realistic maps. So the PR is in on-hold for now.

@Azgaar Azgaar added the POC Proof of Concept label Jul 29, 2024
@Azgaar Azgaar changed the title Draft: Alternative grids [Draft] Alternative grids Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

POC Proof of Concept

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants